Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[11.x] Ignoring column definitions when determining if a blueprint has a create command #52177

Merged
merged 5 commits into from
Jul 18, 2024
Merged

[11.x] Ignoring column definitions when determining if a blueprint has a create command #52177

merged 5 commits into from
Jul 18, 2024

Conversation

kingsven
Copy link
Contributor

Fixes #52175

hafezdivandari
hafezdivandari reviewed Jul 18, 2024
View reviewed changes
Copy link
Contributor

@hafezdivandari hafezdivandari left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may simplify the integration test.

tests/Integration/Database/DatabaseSchemaBlueprintTest.php Outdated Show resolved Hide resolved
@taylorotwell taylorotwell merged commit 1883126 into laravel:11.x Jul 18, 2024
28 of 29 checks passed
@driesvints
Copy link
Member

@hafezdivandari your changes apparently are failing this test. Could you perhaps have a new look and send in a fix?

@hafezdivandari hafezdivandari mentioned this pull request Jul 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hafezdivandari hafezdivandari hafezdivandari left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot add column named create to an existing table
5 participants
@kingsven @driesvints @hafezdivandari @taylorotwell @simonworkhouse